Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake the example blob renderer multi-threaded. #1179
Merged
Conversation
webrender/examples/blob.rs
Outdated
| } | ||
| } | ||
|
|
||
| return Ok(RasterizedBlobImage { |
This comment has been minimized.
This comment has been minimized.
webrender/examples/blob.rs
Outdated
| // The deserialized drawing commands. | ||
| image_cmds: HashMap<ImageKey, ImageRenderingCommands>, | ||
| // We are going to defer the rendering work to worker threads. | ||
| // using a pre-built Arc<Mutex<ThreadPool>> rather than creating our own threads |
This comment has been minimized.
This comment has been minimized.
webrender/examples/blob.rs
Outdated
| fn resolve(&mut self, request: BlobImageRequest) -> BlobImageResult { | ||
| self.rendered_images.remove(&request).unwrap_or(Err(BlobImageError::InvalidKey)) | ||
| // if we break out of the loop above it means the channel closed unexpectedly. | ||
| return Err(BlobImageError::Other("Channel closed".into())); |
This comment has been minimized.
This comment has been minimized.
|
|
|
@nical Needs a rebase. |
|
Yep, I am waiting to see if the switch to rayon sticks before I update this PR for it. |
|
@nical We landed the WR update with rayon in servo today - so it should be fine to update this :) |
|
Seems to be some compile errors on CI. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 17, 2017
Make the example blob renderer multi-threaded. Update the blob image renderer example to render all images in parallel using the (infamous) ThreadPool. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1179) <!-- Reviewable:end -->
|
|
|
OSX timeout, retrying |
bors-servo
added a commit
that referenced
this pull request
May 17, 2017
Make the example blob renderer multi-threaded. Update the blob image renderer example to render all images in parallel using the (infamous) ThreadPool. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1179) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nical commentedApr 28, 2017
•
edited by larsbergstrom
Update the blob image renderer example to render all images in parallel using the (infamous) ThreadPool.
This change is