Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRefactored vLocalRect into vLocalBounds #1192
Merged
+43
−60
Conversation
|
On a side note, I think just using a proper naming convention (*Rect vs *Bounds) is getting most of the benefits that GLSL type system would do for us. |
|
Looks good, thanks. @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 2, 2017
Refactored vLocalRect into vLocalBounds Fixes #1157 r? @glennw <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1192) <!-- Reviewable:end -->
|
|
|
We have reports from Servo users that the symptom from #1157 remains. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kvark commentedMay 2, 2017
•
edited by larsbergstrom
Fixes #1157
r? @glennw
This change is