Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old border code path. #1200

Merged
merged 1 commit into from May 4, 2017
Merged

Conversation

@glennw
Copy link
Member

glennw commented May 4, 2017

This change is Reviewable

@glennw glennw force-pushed the glennw:remove-old-borders branch from b8c7c6f to 7a00191 May 4, 2017
@glennw
Copy link
Member Author

glennw commented May 4, 2017

This PR includes the commit from PR #1199.

Depending on what's easier to review, we can either review #1199 and merge that, then I'll rebase this on top of master, or just review this one PR and close #1199.

r? @kvark

@kvark
kvark approved these changes May 4, 2017
Copy link
Member

kvark left a comment

beautiful, love seeing those ~700 LOC chopped out 👍

@bors-servo
Copy link
Contributor

bors-servo commented May 4, 2017

The latest upstream changes (presumably #1199) made this pull request unmergeable. Please resolve the merge conflicts.

@glennw glennw force-pushed the glennw:remove-old-borders branch from 7a00191 to 88ab4bc May 4, 2017
@glennw
Copy link
Member Author

glennw commented May 4, 2017

@kvark OK, rebased on to master now that the border corner PR has landed.

@kvark
Copy link
Member

kvark commented May 4, 2017

@bors-servo
Copy link
Contributor

bors-servo commented May 4, 2017

📌 Commit 88ab4bc has been approved by kvark

@bors-servo
Copy link
Contributor

bors-servo commented May 4, 2017

Testing commit 88ab4bc with merge c661afa...

bors-servo added a commit that referenced this pull request May 4, 2017
Remove old border code path.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1200)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 4, 2017

☀️ Test successful - status-travis
Approved by: kvark
Pushing c661afa to master...

@bors-servo bors-servo merged commit 88ab4bc into servo:master May 4, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@kvark kvark mentioned this pull request May 8, 2017
3 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.