Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix a couple of correctness issues around border-radius. #122
Conversation
1. Masks for large border radii were not being tessellated properly. This commit simply switches off tessellation for them. Eventually we may want to go back and fix this properly. 2. Border corners were being rendered correctly when 0 < border radius < border width. We needed to do a bit more tessellation than we were. This commit fixes that and adds a diagram to `add_border_corner` to explain what's going on. These commits fix the `border_radius_clip_a.html` and `border_radius_zero_sizes_a.html` reftests.
glennw
added a commit
that referenced
this pull request
Dec 24, 2015
Fix a couple of correctness issues around border-radius.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedDec 24, 2015
This commit simply switches off tessellation for them. Eventually we may
want to go back and fix this properly.
border width. We needed to do a bit more tessellation than we were. This
commit fixes that and adds a diagram to
add_border_cornerto explainwhat's going on.
These commits fix the
border_radius_clip_a.htmlandborder_radius_zero_sizes_a.htmlreftests.