Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the border edge shader to workaround a hang in LLVM 3.8 during shader compilation. #1242

Merged
merged 1 commit into from May 12, 2017
Merged

Rework the border edge shader to workaround a hang in LLVM 3.8 during shader compilation. #1242

merged 1 commit into from May 12, 2017

Conversation

@glennw
Copy link
Member

glennw commented May 12, 2017 •
edited by larsbergstrom

This change is Reviewable
@gw3583
Rework the border edge shader to workaround a hang in LLVM 3.8
Loading status checks…
503d783 
during shader compilation.
@glennw glennw mentioned this pull request May 12, 2017
Merged
@glennw
Copy link
Member Author

glennw commented May 12, 2017

r? @kvark
cc @staktrace
@nical
Copy link
Collaborator

nical commented May 12, 2017

This looks like a good candidate for the driver issues list, @glennw could you give a some details about what the source of the issue is? Is it inlining that ends up generating a lot for the compiler to chew internally?
@staktrace
Copy link
Contributor

staktrace commented May 12, 2017

I managed to get the latest WR building with gecko, so I applied this PR on top of that to see if it fixes the issues. I just kicked it off so results aren't in yet but they will be here. For reference here is the try push with the current WR tip for a comparison baseline.
@kvark
Copy link
Member

kvark commented May 12, 2017

It would be great to have a shiny comment there warning to be careful when shuffling things around. Can be made a follow-up.
@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 12, 2017

📌 Commit 503d783 has been approved by kvark
@bors-servo
Copy link
Contributor

bors-servo commented May 12, 2017

⌛ Testing commit 503d783 with merge 1721fe3...
bors-servo added a commit that referenced this pull request May 12, 2017
@bors-servo
Auto merge of #1242 - glennw:llvm-hack, r=kvark
Loading status checks…
1721fe3 
Rework the border edge shader to workaround a hang in LLVM 3.8 during shader compilation.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1242)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 12, 2017

☀️ Test successful - status-travis
Approved by: kvark
Pushing 1721fe3 to master...
@bors-servo bors-servo merged commit 503d783 into servo:master May 12, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@staktrace
Copy link
Contributor

staktrace commented May 12, 2017

So yes, this PR definitely helped. There's a handful of failures still but I'm not sure which patch they're coming from.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@glennw @nical @staktrace @kvark @bors-servo @gw3583
You can’t perform that action at this time.