Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable gl::XXX_BITS constants in WebGL getParameter command. #1255

Merged
merged 1 commit into from May 16, 2017
Merged

Enable gl::XXX_BITS constants in WebGL getParameter command. #1255

merged 1 commit into from May 16, 2017

Conversation

@MortimerGoro
Copy link
Contributor

MortimerGoro commented May 15, 2017 •
edited by larsbergstrom

Required to pass some WebGL conformance tests. See servo/servo#16867

This change is Reviewable
@MortimerGoro
Enable gl::XXX_BITS constants in WebGL getParameter command.
Loading status checks…
2b75aaa
@MortimerGoro MortimerGoro mentioned this pull request May 15, 2017
Merged
3 of 5 tasks complete
@emilio
Copy link
Member

emilio commented May 15, 2017

@glennw blame points at you for these commented lines (46a7cb1).

Do you remember why was that needed?

If we can uncomment these now, r=me
@glennw
Copy link
Member

glennw commented May 15, 2017

@emilio Some of those were commented due to just not being used. But some of them are not available in ES2, and cause compile errors on android. We now rely on ES3 on android, so some of those may no longer be an issue - but some of them are completely deprecated from ES, I think.
@glennw
Copy link
Member

glennw commented May 15, 2017

@emilio It does look like all the ones that have been un-commented here should be available on Android though, I think!
@glennw
Copy link
Member

glennw commented May 16, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 16, 2017

📌 Commit 2b75aaa has been approved by glennw
@bors-servo
Copy link
Contributor

bors-servo commented May 16, 2017

⌛ Testing commit 2b75aaa with merge 4ab9b9b...
bors-servo added a commit that referenced this pull request May 16, 2017
@bors-servo
Auto merge of #1255 - MortimerGoro:webgl_get_x_bits, r=glennw
Loading status checks…
4ab9b9b 
Enable gl::XXX_BITS constants in WebGL getParameter command.

Required to pass some WebGL conformance tests. See servo/servo#16867

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1255)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 16, 2017

☀️ Test successful - status-travis
Approved by: glennw
Pushing 4ab9b9b to master...
@bors-servo bors-servo merged commit 2b75aaa into servo:master May 16, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@MortimerGoro @emilio @glennw @bors-servo
You can’t perform that action at this time.