Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSurround the statement if switch-case block contains declarations. #1285
+6
−0
Conversation
|
It would be great to add this to the list of driver issues, even if this is not strictly coming from a driver. Or remind me to do it when I come back from vacation next week. |
| @@ -42,11 +42,15 @@ void write_color(vec4 color, float style, bool flip) { | |||
|
|
|||
| switch (int(style)) { | |||
| case BORDER_STYLE_GROOVE: | |||
| { | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mephisto41
May 23, 2017
Author
Contributor
Forget to explain this case. See 1, ANGLE will translate ternary operator to type s; if(b) s = x; else s = y;. And type s is a declaration.
This comment has been minimized.
This comment has been minimized.
|
I'll add it to the wiki. |
|
|
bors-servo
added a commit
that referenced
this pull request
May 23, 2017
Surround the statement if switch-case block contains declarations. This fix #1206 . <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1285) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mephisto41 commentedMay 23, 2017
•
edited by larsbergstrom
This fix #1206 .
This change is