Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBump euclid and heapsize and bump version #1303
Merged
Conversation
|
Looks good, just one question |
webrender/Cargo.toml
Outdated
| @@ -17,7 +17,7 @@ app_units = "0.4" | |||
| bincode = "1.0.0-alpha6" | |||
| bit-set = "0.4" | |||
| byteorder = "1.0" | |||
| euclid = "0.11.2" | |||
| euclid = ">= 0.11, < 0.14" | |||
This comment has been minimized.
This comment has been minimized.
kvark
May 29, 2017
Member
I'm not 100% sure about this being a non-breaking change. Is this approach established elsewhere for a reference?
This comment has been minimized.
This comment has been minimized.
Eijebong
May 29, 2017
Author
Member
Well I didn't change any code so unless you're reexporting euclid somewhere I don't think that this is a breaking change.
This comment has been minimized.
This comment has been minimized.
|
@glennw heads up - this may prevent updating WR for servo until everything is using euclid 0.13 |
|
|
bors-servo
added a commit
that referenced
this pull request
May 30, 2017
Bump euclid and heapsize and bump version <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1303) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Eijebong commentedMay 29, 2017
•
edited
This change is