Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFirst pass of GPU clipping support. #131
Merged
Conversation
|
r? @pcwalton |
|
I get |
* Add support for clip in/out rects on GPU. * Remove CPU polygon clipping code. * Fix all known vertex cracks and pixel sparkling. There is still some code cleanup to do, and missing features, such as: * Nested complex clip regions. * Switching angle gradients to rectangles. * Complex clip regions + border radius. These *should* be fairly simple to implement on top of these changes.
|
@pcwalton That assert is because I haven't done the clip support for box-shadow + border-radius yet. I was going to do that as a follow up PR, so I've commented that assert out for now, if you're ok with doing that as a follow up? |
glennw
added a commit
that referenced
this pull request
Jan 8, 2016
First pass of GPU clipping support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
glennw commentedJan 7, 2016
There is still some code cleanup to do, and missing features, such as:
These should be fairly simple to implement on top of these changes.