Revert the snap rect changes. #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @kvark Sorry! |
4 tasks
|
@kvark is sad 😿 |
|
📌 Commit 9143f1d has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jun 5, 2017
Revert the snap rect changes. I tried several fixes to avoid having to revert this - but it's causing all kinds of weird machine-specific failures on the CI machines. It's also blocking us updating several Servo dependencies at the moment, which are blocked on the WR update for euclid, heapsize etc. We can revisit this after we unblock and land the next WR update. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1339) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
Gankra
added a commit
to Gankra/webrender
that referenced
this pull request
Jun 14, 2017
This reverts servo#1339, which just reverted servo#1292 and servo#1319. The original changes seem to behaving well now. It's unclear what was happening, but whatever it was, it seems fine now! Here is the full list of reverts: Revert "Manually re-apply ANGLE workaround in 3debb57." This reverts commit 9143f1d. Revert "Revert "Full rectangular pixel snapping"" This reverts commit de7e944. Revert "Revert "Snapping transformed primitives"" This reverts commit dae62c5. Revert "Revert "Snapping ref tests"" This reverts commit d6f03ba. Revert "Revert "Ensure that subpixel sized snap rects are at least 1 device pixel."" This reverts commit d396a7e. Revert "Revert "clamp_rect Angle workaround"" This reverts commit ef24b78. Revert "Revert "Don't apply local clip rect to snap rectangle calculation."" This reverts commit 406b102.
Gankra
added a commit
to Gankra/webrender
that referenced
this pull request
Jun 14, 2017
This reverts servo#1339, which just reverted servo#1292 and servo#1319. The original changes seem to behaving well now. It's unclear what was happening, but whatever it was, it seems fine now! Here is the full list of reverts: Revert "Manually re-apply ANGLE workaround in 3debb57." This reverts commit 9143f1d. Revert "Revert "Full rectangular pixel snapping"" This reverts commit de7e944. Revert "Revert "Snapping transformed primitives"" This reverts commit dae62c5. Revert "Revert "Snapping ref tests"" This reverts commit d6f03ba. Revert "Revert "Ensure that subpixel sized snap rects are at least 1 device pixel."" This reverts commit d396a7e. Revert "Revert "clamp_rect Angle workaround"" This reverts commit ef24b78. Revert "Revert "Don't apply local clip rect to snap rectangle calculation."" This reverts commit 406b102.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried several fixes to avoid having to revert this - but it's causing all kinds of weird machine-specific failures on the CI machines.
It's also blocking us updating several Servo dependencies at the moment, which are blocked on the WR update for euclid, heapsize etc.
We can revisit this after we unblock and land the next WR update.
This change is