Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMinor display list refactoring #1346
Merged
Conversation
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 6, 2017
Minor display list refactoring Just a few minor fixes I made while looking at #1345. Haven't got to the root of the problem. That pipeline id lookup couldn't be failing, since it's guaranteed to be checked prior to `flatten_item` (in `flatten_root` and `flatten_iframe`), and then not changed till the rectangles are flattened. So this might be a rogue memory corruption by some unsafe code. Note: specifying examples in `Cargo.toml` is only required if they are not placed directly in `examples/<name>.rs` <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1346) <!-- Reviewable:end -->
|
|
This was referenced Jun 6, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kvark commentedJun 6, 2017
•
edited by larsbergstrom
Just a few minor fixes I made while looking at #1345.
Haven't got to the root of the problem. That pipeline id lookup couldn't be failing, since it's guaranteed to be checked prior to
flatten_item(inflatten_rootandflatten_iframe), and then not changed till the rectangles are flattened. So this might be a rogue memory corruption by some unsafe code.Note: specifying examples in
Cargo.tomlis only required if they are not placed directly inexamples/<name>.rsThis change is