Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for scrolling in iframes. #135
Merged
Conversation
In addition to handling iframe scrolling, this changes items to be in local space relative to their scroll root. This is very much a "work in progress" commit. There's *lots* of things that don't work: * Nested transforms + scroll layers * Render target effects + scroll layers * Render target effects with transforms. However, the changes in this PR are at a stage where all (previously passing) reftests still pass, and it lays the groundwork for supporting those features listed above.
glennw
added a commit
that referenced
this pull request
Jan 13, 2016
Add support for scrolling in iframes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
glennw commentedJan 13, 2016
In addition to handling iframe scrolling, this changes items to be in local space relative to their scroll root.
This is very much a "work in progress" commit. There's lots of things that don't work:
However, the changes in this PR are at a stage where all (previously passing) reftests still pass, and it lays the groundwork for supporting those features listed above.