Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRely on the overflow rect for layer size. #138
Merged
+74
−64
Conversation
glennw
added a commit
that referenced
this pull request
Jan 14, 2016
Rely on the overflow rect for layer size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
glennw commentedJan 14, 2016
This is not currently correct for layers with transformed elements.
According to the spec, the overflow rect should include transformed elements, so this will need to be added/fixed in the layout code rather than WR.
Fixes #137.