Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DisplayListBuilder::with_capacity for finer capacity management by servo/gecko #1399

Merged
merged 1 commit into from Jun 19, 2017

Conversation

@Gankra
Copy link
Contributor

Gankra commented Jun 19, 2017

Gecko makes tons of tiny ones, servo makes one huge one. They need different strategies.


This change is Reviewable

@kvark
Copy link
Member

kvark commented Jun 19, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Jun 19, 2017

📌 Commit 1040690 has been approved by kvark

@bors-servo
Copy link
Contributor

bors-servo commented Jun 19, 2017

Testing commit 1040690 with merge 64b33b4...

bors-servo added a commit that referenced this pull request Jun 19, 2017
Add DisplayListBuilder::with_capacity for finer capacity management by servo/gecko

Gecko makes tons of tiny ones, servo makes one huge one. They need different strategies.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1399)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 19, 2017

☀️ Test successful - status-travis
Approved by: kvark
Pushing 64b33b4 to master...

@bors-servo bors-servo merged commit 1040690 into servo:master Jun 19, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
bors-servo added a commit to servo/servo that referenced this pull request Jul 24, 2017
use DisplayListBuilder::with_capacity

DO NOT MERGE until servo/webrender#1399 has landed in Servo.

Previously webrender was reserving 1MB of space for each display list (empirically pages weighed between 100k and 10MB when I implemented this). This was problematic for gecko because they used webrender differently. This just brings Servo back to where it was.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17406)
<!-- Reviewable:end -->
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jul 25, 2017
…kro:with_cap); r=jdm

DO NOT MERGE until servo/webrender#1399 has landed in Servo.

Previously webrender was reserving 1MB of space for each display list (empirically pages weighed between 100k and 10MB when I implemented this). This was problematic for gecko because they used webrender differently. This just brings Servo back to where it was.

Source-Repo: https://github.com/servo/servo
Source-Revision: 3629efba7508bf115ad0127d2567af7090a9f8ca

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 2f8907f18d78e9a546a487ca0a0035db4a9450f6
JerryShih pushed a commit to JerryShih/gecko-dev that referenced this pull request Jul 27, 2017
…kro:with_cap); r=jdm

DO NOT MERGE until servo/webrender#1399 has landed in Servo.

Previously webrender was reserving 1MB of space for each display list (empirically pages weighed between 100k and 10MB when I implemented this). This was problematic for gecko because they used webrender differently. This just brings Servo back to where it was.

Source-Repo: https://github.com/servo/servo
Source-Revision: 3629efba7508bf115ad0127d2567af7090a9f8ca
aethanyc pushed a commit to aethanyc/gecko-dev that referenced this pull request Jul 28, 2017
…kro:with_cap); r=jdm

DO NOT MERGE until servo/webrender#1399 has landed in Servo.

Previously webrender was reserving 1MB of space for each display list (empirically pages weighed between 100k and 10MB when I implemented this). This was problematic for gecko because they used webrender differently. This just brings Servo back to where it was.

Source-Repo: https://github.com/servo/servo
Source-Revision: 3629efba7508bf115ad0127d2567af7090a9f8ca
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 1, 2019
…kro:with_cap); r=jdm

DO NOT MERGE until servo/webrender#1399 has landed in Servo.

Previously webrender was reserving 1MB of space for each display list (empirically pages weighed between 100k and 10MB when I implemented this). This was problematic for gecko because they used webrender differently. This just brings Servo back to where it was.

Source-Repo: https://github.com/servo/servo
Source-Revision: 3629efba7508bf115ad0127d2567af7090a9f8ca

UltraBlame original commit: 9dd60bf73988336871b087627eb849f043a43e5c
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 1, 2019
…kro:with_cap); r=jdm

DO NOT MERGE until servo/webrender#1399 has landed in Servo.

Previously webrender was reserving 1MB of space for each display list (empirically pages weighed between 100k and 10MB when I implemented this). This was problematic for gecko because they used webrender differently. This just brings Servo back to where it was.

Source-Repo: https://github.com/servo/servo
Source-Revision: 3629efba7508bf115ad0127d2567af7090a9f8ca

UltraBlame original commit: 9dd60bf73988336871b087627eb849f043a43e5c
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 1, 2019
…kro:with_cap); r=jdm

DO NOT MERGE until servo/webrender#1399 has landed in Servo.

Previously webrender was reserving 1MB of space for each display list (empirically pages weighed between 100k and 10MB when I implemented this). This was problematic for gecko because they used webrender differently. This just brings Servo back to where it was.

Source-Repo: https://github.com/servo/servo
Source-Revision: 3629efba7508bf115ad0127d2567af7090a9f8ca

UltraBlame original commit: 9dd60bf73988336871b087627eb849f043a43e5c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.