Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upframe_builder: Don't use subpixel AA for non-opaque text. #1423
Conversation
This fixes servo/servo#17464. Not 100% sure it's the correct fix, but it seemed reasonable given we disable it for non-opaque stacking contexts.
|
@emilio Yup, it's certainly an improvement over what we have - we can look at a "proper" solution later. Thanks! @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 23, 2017
frame_builder: Don't use subpixel AA for non-opaque text. This fixes servo/servo#17464. Not 100% sure it's the correct fix, but it seemed reasonable given we disable it for non-opaque stacking contexts. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1423) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
emilio commentedJun 22, 2017
•
edited by larsbergstrom
This fixes servo/servo#17464.
Not 100% sure it's the correct fix, but it seemed reasonable given we disable it
for non-opaque stacking contexts.
This change is