Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the clipping and scrolling API #1428

Merged
merged 4 commits into from Jul 10, 2017
Merged

Commits on Jul 6, 2017

  1. Add a define_scroll_frame API

    This makes it explicit whether or not you are creating a ScrollFrame
    when using the API. Before this was based on the content size of the
    clip, which was awkward and could lead to weird situations where you
    created a ScrollFrame when you didn't mean to or the reverse.
    
    Fixes #1335.
    mrobinson committed Jul 6, 2017

Commits on Jul 7, 2017

  1. Make clip coordinates relative to stacking context

    Clip coordinates previously used a weird coordinate space relative to
    the origin of the display item. This was different than every other
    coordinate specified in the display list, so we smooth over this
    wrinkle. To do this we need to copy out the complex clips from the
    auxiliary list and adjust them so that they are relative to the scroll
    clip node.
    
    Fixes #1090.
    Fixes #1408.
    mrobinson committed Jul 7, 2017
  2. Add rounded rectangles for local clip

    This is a slight revert of the removal of per-item complex clips, but
    these clips are important for Servo.
    mrobinson committed Jul 7, 2017
  3. Update the WebRender version

    This is necessary because of the changes to the API.
    mrobinson committed Jul 7, 2017
You can’t perform that action at this time.