Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd a way to remove all resources from the resource cache that have a certain namespace #1435
Conversation
… certain namespace. This is a tad ugly but it makes it a lot easier in firefox when a content-process crashes, to clean up every resources that were associated to it. The alternative is to maintain a map of all of the image and font keys in use in gecko-land.
| @@ -62,6 +62,7 @@ pub enum ApiMsg { | |||
| /// to forward gecko-specific messages to the render thread preserving the ordering | |||
| /// within the other messages. | |||
| ExternalEvent(ExternalEvent), | |||
| RemoveAllResourcesWithNamespace(IdNamespace), | |||
This comment has been minimized.
This comment has been minimized.
| @@ -764,6 +764,11 @@ impl ResourceCache { | |||
| debug_assert_eq!(self.state, State::QueryResources); | |||
| self.state = State::Idle; | |||
| } | |||
|
|
|||
| pub fn remove_all_resources_with_namespace(&mut self, namespace: IdNamespace) { | |||
| self.resources.image_templates.images.retain(|key: &ImageKey, _|{ key.0 != namespace.0 }); | |||
This comment has been minimized.
This comment has been minimized.
|
|
|
Replaced by #1445 |
bors-servo
added a commit
that referenced
this pull request
Jul 20, 2017
Clear resources in a namespace Builds upon #1435 cc @nical r? @glennw <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1445) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nical commentedJun 29, 2017
•
edited by larsbergstrom
This is a tad ugly but it makes it a lot easier in firefox when a content-process crashes, to clean up every resources that were associated to it. The alternative is to maintain a map of all of the image and font keys in use in gecko-land.
This change is