Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed snap rectangle for the glyph runs #1441

Merged
merged 1 commit into from Jun 30, 2017
Merged

Fixed snap rectangle for the glyph runs #1441

merged 1 commit into from Jun 30, 2017

Conversation

@kvark
Copy link
Member

kvark commented Jun 29, 2017 •
edited by larsbergstrom

r? @glennw
cc @mrobinson

This change is Reviewable
@kvark
Fixed snap rectangle for the glyph runs
Loading status checks…
6d91c35
@glennw
Copy link
Member

glennw commented Jun 30, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2017

📌 Commit 6d91c35 has been approved by glennw
@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2017

⌛ Testing commit 6d91c35 with merge 37bd665...
bors-servo added a commit that referenced this pull request Jun 30, 2017
@bors-servo
Auto merge of #1441 - kvark:glyph-snap, r=glennw
Loading status checks…
37bd665 
Fixed snap rectangle for the glyph runs

r? @glennw
cc @mrobinson

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1441)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2017

☀️ Test successful - status-travis
Approved by: glennw
Pushing 37bd665 to master...
@bors-servo bors-servo merged commit 6d91c35 into servo:master Jun 30, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@kvark kvark deleted the kvark:glyph-snap branch Jun 30, 2017
@staktrace
Copy link
Contributor

staktrace commented Jul 4, 2017

@kvark This PR caused a gecko reftest regression in layout/reftests/stylesheet-cloning/counter-style-rule-clone.html. Links to reftest analyzer and try push
@kvark kvark mentioned this pull request Jul 4, 2017
Closed
@kvark
Copy link
Member Author

kvark commented Jul 4, 2017

@staktrace
Interesting! Perhaps, we should be snapping to something else then the primitive rect.
Created #1451 to investigate
@kvark
Copy link
Member Author

kvark commented Jul 5, 2017 •
edited

@staktrace I verified that it's not #1441 that broke the test. I suspect it's the mix of #1441 with #1375
Nvm! I was using the wrong branch, and I see that #1375 is already in
bors-servo added a commit that referenced this pull request Jul 6, 2017
@bors-servo
Auto merge of #1455 - kvark:text-snap, r=glennw
Loading status checks…
8ca0041 
Glyph snapping - revert of #1441

Fixes #1451
@staktrace I didn't see much of a difference locally. Would you be able to verify if this works?

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1455)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@kvark @glennw @bors-servo @staktrace
You can’t perform that action at this time.