Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upClear resources in a namespace #1445
Conversation
|
|
kvark
force-pushed the
kvark:namespace
branch
3 times, most recently
from
0c6cd5b
to
54d23fd
| @@ -764,6 +764,24 @@ impl ResourceCache { | |||
| debug_assert_eq!(self.state, State::QueryResources); | |||
| self.state = State::Idle; | |||
| } | |||
|
|
|||
| pub fn clear_namespace(&mut self, namespace: IdNamespace) { | |||
| //TODO: use `retain` when we are on Rust-1.18 | |||
This comment has been minimized.
This comment has been minimized.
glennw
Jul 5, 2017
Member
We'll want to also remove the items from the texture cache, if they exist in there, I guess?
This comment has been minimized.
This comment has been minimized.
nical
Jul 6, 2017
Collaborator
These would eventually expire on their own, right? But yeah sounds like it would be a good thing to do as well, and also remove items from the texture cache when removing image and font templates.
|
Oops, reopening |
|
@kvark I think this just needs an update to remove items from the texture cache, if that's feasible. |
|
@glennw please take another look |
|
@kvark Looks good! r=me, do you need to remove the text-shadow commit that is in here? Or will git handle that cleanly? |
|
@bors-servo r+ |
|
|
Clear resources in a namespace Builds upon #1435 cc @nical r? @glennw <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1445) <!-- Reviewable:end -->
|
|
kvark commentedJun 30, 2017
•
edited by larsbergstrom
Builds upon #1435
cc @nical
r? @glennw
This change is