Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat all clips as scroll frames (partial revert of #1412) #1459

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

@@ -345,8 +345,10 @@ impl Frame {
item: &ClipDisplayItem,
content_rect: &LayerRect,
clip: &ClipRegion) {
let is_scroll_frame =
clip.main.origin != LayerPoint::zero() || clip.main.size != content_rect.size;
// Until we have an explicit API to allow WR users to create scroll
// frames, we treat all clips as scroll frames. Once that API is in
// place this can be updated accordingly.
let is_scroll_frame = true;

let new_id = context.convert_new_id_to_neested(&item.id);
let new_clip_id = if is_scroll_frame {
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.