Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement dotted borders. #15
Merged
Conversation
Known issues: * The corners are not dotted. This affects dashed borders too. The simple fix will be to disable corner drawing if there is no border-radius. * Nearest-neighbor texture sampling doesn't work well if the border dots are an odd number of pixels. We'll need to make some sort of policy decision here as to what to do, as this may come up in other situations, so I'll defer the fix for that pending further discussion.
nox
pushed a commit
to nox/webrender
that referenced
this pull request
Aug 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedOct 11, 2015
Known issues:
simple fix will be to disable corner drawing if there is no
border-radius.
are an odd number of pixels. We'll need to make some sort of policy
decision here as to what to do, as this may come up in other
situations, so I'll defer the fix for that pending further discussion.