Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dotted borders. #15

Merged
merged 1 commit into from Oct 11, 2015
Merged

Implement dotted borders. #15

merged 1 commit into from Oct 11, 2015

Conversation

@pcwalton
Copy link
Collaborator

pcwalton commented Oct 11, 2015

Known issues:

  • The corners are not dotted. This affects dashed borders too. The
    simple fix will be to disable corner drawing if there is no
    border-radius.
  • Nearest-neighbor texture sampling doesn't work well if the border dots
    are an odd number of pixels. We'll need to make some sort of policy
    decision here as to what to do, as this may come up in other
    situations, so I'll defer the fix for that pending further discussion.
Known issues:

* The corners are not dotted. This affects dashed borders too. The
  simple fix will be to disable corner drawing if there is no
  border-radius.

* Nearest-neighbor texture sampling doesn't work well if the border dots
  are an odd number of pixels. We'll need to make some sort of policy
  decision here as to what to do, as this may come up in other
  situations, so I'll defer the fix for that pending further discussion.
glennw added a commit that referenced this pull request Oct 11, 2015
Implement dotted borders.
@glennw glennw merged commit c9d629d into servo:master Oct 11, 2015
@pcwalton pcwalton deleted the pcwalton:dotting branch Oct 11, 2015
nox pushed a commit to nox/webrender that referenced this pull request Aug 6, 2016
Flatten the WebRender API to allow us to use shared memory to transfer display lists.

Improves performance significantly.

r? @glennw
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.