Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upVarious improvements to benchmark mode, plus a glyph stress benchmark. #1514
Conversation
|
r? @kvark |
glennw
force-pushed the
glennw:benchmarks-text
branch
2 times, most recently
from
4104bdd
to
3d5e4a8
|
Rebased. |
|
A few nits, otherwise gold to go |
wrench/src/args.yaml
Outdated
| @@ -24,10 +24,10 @@ args: | |||
| long: save | |||
| help: 'Save frames, one of: yaml, json, or binary' | |||
| takes_value: true | |||
| - subpixel_aa: | |||
| - disable_subpixel_aa: | |||
This comment has been minimized.
This comment has been minimized.
wrench/src/main.rs
Outdated
| @@ -320,7 +320,7 @@ fn main() { | |||
| save_type, | |||
| size, | |||
| args.is_present("rebuild"), | |||
| args.is_present("subpixel_aa"), | |||
| !args.is_present("disable_subpixel_aa"), | |||
This comment has been minimized.
This comment has been minimized.
kvark
Jul 26, 2017
Member
similarly, we might want to move the inversion ! later down the pipe in order to be consistent with the other options
wrench/src/perf.rs
Outdated
|
|
||
| TestProfile { | ||
| name: filename.to_str().unwrap().to_string(), | ||
| composite_time_ns: composite_time / cpu_samples.len() as u64, | ||
| paint_time_ns: paint_time / gpu_samples.len() as u64, | ||
| composite_time_ns: composite_time_ns, |
This comment has been minimized.
This comment has been minimized.
kvark
Jul 26, 2017
Member
nit: looks like you haven't gotten used to the new shiny Rust 1.16 features yet :)
| draw_calls, | ||
| } | ||
| } | ||
| } | ||
|
|
||
| fn extract_sample<F, T>(profiles: &mut [T], f: F) -> u64 where F: Fn(&T) -> u64 { |
This comment has been minimized.
This comment has been minimized.
* Track the CPU backend time in benchmark mode. * Add a glyph rendering stress test. * Make subpixel AA default text mode in wrench. * Rebuild display lists every frame in benchmark mode.
|
@kvark Thanks, fixed those nits. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 26, 2017
Various improvements to benchmark mode, plus a glyph stress benchmark. * Track the CPU backend time in benchmark mode. * Add a glyph rendering stress test. * Make subpixel AA default text mode in wrench. * Rebuild display lists every frame in benchmark mode. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1514) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
glennw commentedJul 25, 2017
•
edited by larsbergstrom
This change is