Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix incorrectly deleted resources in clear_namespace function. #1524
Conversation
|
Ooops! |
MortimerGoro
force-pushed the
MortimerGoro:clear_namespace
branch
from
b6a6a42
to
4cd3aa4
|
Ok, Done! |
|
Thank you! |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 26, 2017
Fix incorrectly deleted resources in clear_namespace function. clear_namespace function is removing resources from different namespaces from the IdNamespace argument. Image_keys and font_keys are filtered by `key.0 != namespace` instead of `key.0 == namespace` Rust-1.18 is already available so I used the retain function to fix both the issue and the TODO. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1524) <!-- Reviewable:end -->
|
|
|
By the way, rustc min version is 1.17 for gecko now with Bug 1374807. https://dxr.mozilla.org/mozilla-central/source/build/moz.configure/rust.configure#58 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
MortimerGoro commentedJul 26, 2017
•
edited
clear_namespace function is removing resources from different namespaces from the IdNamespace argument. Image_keys and font_keys are filtered by
key.0 != namespaceinstead ofkey.0 == namespaceRust-1.18 is already available so I used the retain function to fix both the issue and the TODO.
This change is