Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upText rendering optimizations and bug fixes. #1525
Merged
Conversation
|
r? @kvark (I've run the tests on Linux / Mac). |
glennw
force-pushed the
glennw:subpx-dir
branch
2 times, most recently
from
824cf5a
to
2fb74a2
|
|
* Switch subpixel positioning to be applied on one axis only. Subpixel positioning only needs to be applied on the axis of the text run direction. Reduces the number of glyphs rasterized significantly, saving texture memory and CPU time. * Switch shader truncating of text run vertices to be based on the subpixel positioning direction. * Apply subpixel positioning to alpha AA text runs (including shadows). * Fix a bug in Linux subpixel AA mode where the dimensions didn't match the bitmap.
|
Rebased |
|
@bors-servo r+
… On Jul 27, 2017, at 20:08, Glenn Watson ***@***.***> wrote:
Rebased
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 28, 2017
Text rendering optimizations and bug fixes. * Switch subpixel positioning to be applied on one axis only. Subpixel positioning only needs to be applied on the axis of the text run direction. Reduces the number of glyphs rasterized significantly, saving texture memory and CPU time. * Switch shader truncating of text run vertices to be based on the subpixel positioning direction. * Apply subpixel positioning to alpha AA text runs (including shadows). * Fix a bug in Linux subpixel AA mode where the dimensions didn't match the bitmap. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1525) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
glennw commentedJul 27, 2017
•
edited by larsbergstrom
Subpixel positioning only needs to be applied on the axis of the text run direction.
Reduces the number of glyphs rasterized significantly, saving texture memory and CPU time.
This change is