Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up of the image request code in the texture cache. #1531

Merged
merged 1 commit into from Jul 31, 2017

Conversation

@glennw
Copy link
Member

glennw commented Jul 31, 2017

This is prep work for some upcoming work to reduce the amount
of hashing we do in the resource cache.


This change is Reviewable

This is prep work for some upcoming work to reduce the amount
of hashing we do in the resource cache.
@glennw
Copy link
Member Author

glennw commented Jul 31, 2017

r? @kvark and @nical

As far as I can tell, this shouldn't change any semantics. But please take a careful look at this one :)

@nical
nical approved these changes Jul 31, 2017
Copy link
Collaborator

nical left a comment

Looks good to me!

@kvark
kvark approved these changes Jul 31, 2017
@kvark
Copy link
Member

kvark commented Jul 31, 2017

Pretty!
@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Jul 31, 2017

📌 Commit a77fc5d has been approved by kvark

@bors-servo
Copy link
Contributor

bors-servo commented Jul 31, 2017

Testing commit a77fc5d with merge 1329eb9...

bors-servo added a commit that referenced this pull request Jul 31, 2017
Tidy up of the image request code in the texture cache.

This is prep work for some upcoming work to reduce the amount
of hashing we do in the resource cache.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1531)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 31, 2017

☀️ Test successful - status-travis
Approved by: kvark
Pushing 1329eb9 to master...

@bors-servo bors-servo merged commit a77fc5d into servo:master Jul 31, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@glennw glennw deleted the glennw:tc-tidy branch Jul 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.