Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFail initialization if the max texture size is insufficient. #1563
Conversation
|
Moved this sanity check to the beginning of the function to not bother with creating shaders, threads and other resources. r? @kvark |
|
Thanks, looking good! |
|
|
Fail initialization if the max texture size is insufficient. This works around #1260 ([driver issues entry](https://github.com/servo/webrender/wiki/Driver-issues#1260---broken-gl-context-reports-max-texture-size-equal-to-zero)) by gracefully failing the initialization instead of panicking the first time we try to allocate a texture cache page. This should let us fallback to another compositor backend and more easily identify the issue when it happens.
|
|
|
@nical y u no compile? :)
|
|
oops, did a last minute change and apparently forgot to build it. This version does build locally now. |
|
@bors-servo r=kvark,glennw |
|
|
Fail initialization if the max texture size is insufficient. This works around #1260 ([driver issues entry](https://github.com/servo/webrender/wiki/Driver-issues#1260---broken-gl-context-reports-max-texture-size-equal-to-zero)) by gracefully failing the initialization instead of panicking the first time we try to allocate a texture cache page. This should let us fallback to another compositor backend and more easily identify the issue when it happens.
|
|
nical commentedAug 9, 2017
This works around #1260 (driver issues entry) by gracefully failing the initialization instead of panicking the first time we try to allocate a texture cache page.
This should let us fallback to another compositor backend and more easily identify the issue when it happens.