Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix bug I introduced during the render task tree refactor in composites. #1598
Conversation
|
r? @kvark cc @staktrace This passes the wrench tests, Servo WPT/CSS suite. I've tested the A complete Gecko try run is pending: https://hg.mozilla.org/try/rev/c4f6acfc28b562ff1fc1face225ff81b5c6aa8fa |
|
I'm still working on a local wrench test that will reproduce the bug to prevent regressions in the future, but this can be reviewed now. |
|
Added a regression reftest for this bug, and the try run looks like it is green now. |
|
Oh, that wasn't obvious |
|
@bors-servo r+ |
|
|
|
Wrench fails to build on windows though: |
|
Try push seems to be green - https://treeherder.mozilla.org/#/jobs?repo=try&revision=c4f6acfc28b562ff1fc1face225ff81b5c6aa8fa |
Fix bug I introduced during the render task tree refactor in composites. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1598) <!-- Reviewable:end -->
|
@kvark Thanks! The windows / appveyor failures are occurring on all PRs at the moment. I haven't had a chance to look into it - I suspect the rustc version might be the cause? |
|
|
Fix bug I introduced during the render task tree refactor in composites. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1598) <!-- Reviewable:end -->
|
|
glennw commentedAug 22, 2017
•
edited by larsbergstrom
This change is