Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd the mut keyword for font_key_from_native_handle() in windows platform #1599
Conversation
…form. Fix the build break in windows. The add_native_font() call in this function needs a mutable variable.
|
@bors-servo r+ |
|
|
|
@bors-servo p=100 force |
|
@bors-servo are you still there? |
|
|
|
@bors-servo r=glennw |
|
|
|
|
@bors-servo r=glennw yes i know it's already approved but please tell me why you're blocked, homu |
|
|
|
|
@bors-servo p=100 |
|
@bors-servo r=glennw please tell me it's redundant |
|
|
|
|
|
|
|
|
@bors-servo r+ |
|
|
|
Add the mut keyword for font_key_from_native_handle() in windows platform @glennw r? Fix the build break in windows. The add_native_font() call in this function needs a mutable variable. --> src\wrench.rs:277:9 | 276 | let resources = ResourceUpdates::new(); | --------- consider changing this to `mut resources` 277 | resources.add_native_font(key, descriptor.clone()); | ^^^^^^^^^ cannot borrow mutably error: aborting due to previous error <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1599) <!-- Reviewable:end -->
|
@bors-servo force clean retry |
|
@bors-servo r+ |
|
|
|
Add the mut keyword for font_key_from_native_handle() in windows platform @glennw r? Fix the build break in windows. The add_native_font() call in this function needs a mutable variable. --> src\wrench.rs:277:9 | 276 | let resources = ResourceUpdates::new(); | --------- consider changing this to `mut resources` 277 | resources.add_native_font(key, descriptor.clone()); | ^^^^^^^^^ cannot borrow mutably error: aborting due to previous error <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1599) <!-- Reviewable:end -->
|
@edunham doesn't look like this PR is going to give up easily |
|
Closing in favour of #1610 due to bors / travis issues. |
JerryShih commentedAug 23, 2017
•
edited by larsbergstrom
@glennw r?
Fix the build break in windows. The add_native_font() call in this function needs a mutable variable.
--> src\wrench.rs:277:9
|
276 | let resources = ResourceUpdates::new();
| --------- consider changing this to
mut resources277 | resources.add_native_font(key, descriptor.clone());
| ^^^^^^^^^ cannot borrow mutably
error: aborting due to previous error
This change is