Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix texture cache profiler display. #1638

Merged
merged 1 commit into from Aug 31, 2017
Merged

Conversation

@glennw
Copy link
Member

glennw commented Aug 31, 2017

This was disabled when the new texture cache allocator was merged.
The numbers aren't super meaningful right now, since the caches
don't grow, but they at least show which texture caches are
allocated and what the fixed size of them is.

Fixes #1637


This change is Reviewable

This was disabled when the new texture cache allocator was merged.
The numbers aren't super meaningful right now, since the caches
don't grow, but they at least show which texture caches are
allocated and what the fixed size of them is.
@glennw
Copy link
Member Author

glennw commented Aug 31, 2017

r? @nical

@nical
Copy link
Collaborator

nical commented Aug 31, 2017

Thanks!

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2017

📌 Commit da0b213 has been approved by nical

@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2017

Testing commit da0b213 with merge 3ed4591...

bors-servo added a commit that referenced this pull request Aug 31, 2017
Fix texture cache profiler display.

This was disabled when the new texture cache allocator was merged.
The numbers aren't super meaningful right now, since the caches
don't grow, but they at least show which texture caches are
allocated and what the fixed size of them is.

Fixes #1637

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1638)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2017

☀️ Test successful - status-travis
Approved by: nical
Pushing 3ed4591 to master...

@bors-servo bors-servo merged commit da0b213 into servo:master Aug 31, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@staktrace
Copy link
Contributor

staktrace commented Aug 31, 2017

@glennw The bytes_per_pixel change caused gecko build bustage.

https://bugzilla.mozilla.org/show_bug.cgi?id=1395237#c3

@staktrace
Copy link
Contributor

staktrace commented Aug 31, 2017

@glennw (btw i already fixed the above issue, no need for you to do anything - that was just an fyi to consider for future changes)

@glennw glennw deleted the glennw:fix-tc-profile branch Aug 31, 2017
@glennw
Copy link
Member Author

glennw commented Aug 31, 2017

@staktrace Ah, I missed that one. Apologies!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.