Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in handling redundant opacity filters. #1673

Merged
merged 1 commit into from Sep 8, 2017
Merged

Conversation

@glennw
Copy link
Member

glennw commented Sep 7, 2017

If a filter had a property binding, and that value resolved
to opacity=1, WR can skip applying an expensive filter
operation on that stacking context.


This change is Reviewable

If a filter had a property binding, and that value resolved
to opacity=1, WR can skip applying an expensive filter
operation on that stacking context.
@glennw
Copy link
Member Author

glennw commented Sep 7, 2017

r? @kvark

This helps quite a bit with #1670.

@kvark
kvark approved these changes Sep 7, 2017
@kvark
Copy link
Member

kvark commented Sep 7, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Sep 7, 2017

📌 Commit 57613e9 has been approved by kvark

bors-servo added a commit that referenced this pull request Sep 7, 2017
Fix bug in handling redundant opacity filters.

If a filter had a property binding, and that value resolved
to opacity=1, WR can skip applying an expensive filter
operation on that stacking context.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1673)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 7, 2017

Testing commit 57613e9 with merge 292b5ff...

@bors-servo
Copy link
Contributor

bors-servo commented Sep 7, 2017

Testing commit 57613e9 with merge 3207dd5...

bors-servo added a commit that referenced this pull request Sep 7, 2017
Fix bug in handling redundant opacity filters.

If a filter had a property binding, and that value resolved
to opacity=1, WR can skip applying an expensive filter
operation on that stacking context.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1673)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 8, 2017

Testing commit 57613e9 with merge 39ce371...

bors-servo added a commit that referenced this pull request Sep 8, 2017
Fix bug in handling redundant opacity filters.

If a filter had a property binding, and that value resolved
to opacity=1, WR can skip applying an expensive filter
operation on that stacking context.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1673)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 8, 2017

☀️ Test successful - status-travis
Approved by: kvark
Pushing 39ce371 to master...

@bors-servo bors-servo merged commit 57613e9 into servo:master Sep 8, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.