Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake batch updates and delivery of a new frame into an atomic operation. #169
+5
−12
Conversation
Before this patch, there was a chance that batch updates could be delivered to the compositor thread (destroying old resources) and then a render operation could be invoked before arrival of the new frame. This would cause the compositor thread to attempt to render frame N with the resources of frame N+1, which would usually crash. Closes #160.
|
Nice catch! |
glennw
added a commit
that referenced
this pull request
Feb 3, 2016
Make batch updates and delivery of a new frame into an atomic operation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedFeb 3, 2016
Before this patch, there was a chance that batch updates could be
delivered to the compositor thread (destroying old resources) and then a
render operation could be invoked before arrival of the new frame. This
would cause the compositor thread to attempt to render frame N with the
resources of frame N+1, which would usually crash.
Closes #160.