Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix buggy texelFetchOffset calls on Android #1696
Conversation
| @@ -21,6 +21,14 @@ | |||
| #define TEX_SAMPLE(sampler, tex_coord) textureLod(sampler, tex_coord, 0.0) | |||
| #endif | |||
|
|
|||
| // texelFetchOffset has driver bugs on some Android GPUs (see issue #1694). | |||
| // Fallback to texelFetch on mobile GPUs. | |||
| #if defined(GL_ES) && GL_ES == 1 | |||
This comment has been minimized.
This comment has been minimized.
glennw
Sep 12, 2017
Member
I think we've had a bug previously where some (mobile) shader compilers didn't handle the && properly. Could you switch it to use the same #ifdef setup for HIGHP_SAMPLER_FLOAT in shared.glsl?
This comment has been minimized.
This comment has been minimized.
leeoniya
commented
Sep 12, 2017
|
candidate for https://github.com/servo/webrender/wiki/Driver-issues ? |
|
@leeoniya Looks like the relevant bug is listed there already :) https://github.com/servo/webrender/wiki/Driver-issues#---mac-glsl-compiler-bug-realted-to-logical-operators-in-if-blocks |
MortimerGoro
force-pushed the
MortimerGoro:texel_fetch_android
branch
from
e0e5a0d
to
207eedd
|
Ok, used nested #ifs to workaround the parser bug. What a driver party! |
|
Looks good, thanks! @bors-servo r+ |
|
|
leeoniya
commented
Sep 12, 2017
|
@glennw ah, cool. is there any benefit in linking related issues in the wiki since they may surface in different contexts. |
|
@leeoniya Yep, I think that would be useful. |
|
@MortimerGoro @leeoniya Ah, yes - we should definitely add the |
leeoniya
commented
Sep 12, 2017
|
yeah, sry i meant the |
Fix buggy texelFetchOffset calls on Android Fixes servo/servo#17621, servo/servo#17851 and #1694 texelFetchOffset is very buggy on some Android GPUs... <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1696) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
Fix buggy texelFetchOffset calls on Android Fixes servo/servo#17621, servo/servo#17851 and #1694 texelFetchOffset is very buggy on some Android GPUs... <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1696) <!-- Reviewable:end -->
leeoniya
commented
Sep 13, 2017
|
i added the wiki entry here: https://github.com/servo/webrender/wiki/Driver-issues#1694---texelfetchoffset-is-very-buggy-on-some-android-gpus plz correct as necessary |
|
|
|
Hm
@bors-servo retry |
|
oh wow, looks like github has screwed me up a bit |
MortimerGoro commentedSep 12, 2017
•
edited by larsbergstrom
Fixes servo/servo#17621, servo/servo#17851 and #1694
texelFetchOffset is very buggy on some Android GPUs...
This change is