Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd some factories for PrimitiveInfo #1708
Conversation
|
Nice reduction in LOC! |
| is_backface_visible: true, | ||
| }; | ||
|
|
||
| let info = LayoutPrimitiveInfo::new_with_clip_rect(rect, bounds); |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| local_clip: Some(api::LocalClip::from(bounds)), | ||
| is_backface_visible: true, | ||
| }; | ||
| let info = api::LayoutPrimitiveInfo::new((30, 30).by(500, 500)); |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| local_clip: Some(api::LocalClip::from(bounds)), | ||
| is_backface_visible: true, | ||
| }; | ||
| let info = api::LayoutPrimitiveInfo::new((600, 600).by(200, 200)); |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
This will make it easier to add new members in the future (for hit testing). We also make local_clip a LocalClip instead of an Option<LocalClip> because this should never be None.
|
Okay. I've updated the branch with the changes and rebased it on top of the rustfmt changes. |
|
Thanks @mrobinson , and sorry about the rebase pain! |
|
|
Add some factories for PrimitiveInfo This will make it easier to add new members in the future (for hit testing). We also make local_clip a LocalClip instead of an Option<LocalClip> because this should never be None. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1708) <!-- Reviewable:end -->
|
|
|
@mrobinson This broke the gecko build, please see https://bugzilla.mozilla.org/show_bug.cgi?id=1400216#c5 and provide a gecko-side patch. Thanks! |
|
@staktrace Thanks for the heads up. I've posted a patch to Bugzilla which should fix the build. |
mrobinson commentedSep 15, 2017
•
edited by larsbergstrom
This will make it easier to add new members in the future (for hit
testing). We also make local_clip a LocalClip instead of an
Option because this should never be None.
This change is