Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRustfmt pass #1712
Merged
Rustfmt pass #1712
Conversation
|
Thanks for doing this! CI is failing due to
|
|
Any issues about the new style? |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 18, 2017
Rustfmt pass The settings are mostly default, I find them quite reasonable. I didn't touch `debug_font_data` since it just needs to be rewritten with `include_bin!`. I didn't touch `debug_colors` since I wasn't convinced it's worth it. Possibly disable formatting on that file as a follow up. r? @glennw <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1712) <!-- Reviewable:end -->
|
|
This was referenced Sep 18, 2017
If the transform contains perspective component, the clip rect don't affect by this transform.
#1693
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kvark commentedSep 17, 2017
•
edited by larsbergstrom
The settings are mostly default, I find them quite reasonable.
I didn't touch
debug_font_datasince it just needs to be rewritten withinclude_bin!.I didn't touch
debug_colorssince I wasn't convinced it's worth it. Possibly disable formatting on that file as a follow up.r? @glennw
This change is