Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake subpixel positioning match that of Gecko. #1715
Merged
Conversation
| assert_eq!(rm.subpixel_quantize_offset(0.0), SubpixelOffset::Zero); | ||
| assert_eq!(rm.subpixel_quantize_offset(-0.0), SubpixelOffset::Zero); | ||
|
|
||
| assert_eq!(rm.subpixel_quantize_offset(0.1), SubpixelOffset::Zero); |
This comment has been minimized.
This comment has been minimized.
kvark
Sep 18, 2017
Member
nit: could be nicer if those subpixel_quantize_offset calls are batched per expected SubpixelOffset
|
Tests are green, merging. |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 18, 2017
Make subpixel positioning match that of Gecko. Simplify the quantization function, and add unit tests. Modify the shader to correctly add the glyph subpixel offset before truncating the value. With these changes, the glyph rendering is pixel-perfect with Gecko in all the test cases I checked. Fixes #1270. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1715) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
glennw commentedSep 18, 2017
•
edited by larsbergstrom
Simplify the quantization function, and add unit tests.
Modify the shader to correctly add the glyph subpixel offset
before truncating the value.
With these changes, the glyph rendering is pixel-perfect with
Gecko in all the test cases I checked.
Fixes #1270.
This change is