Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workarounds for a driver bug that seems to cause shaders to be miscompiled. #1740

Merged
merged 1 commit into from Sep 21, 2017
Merged

Add workarounds for a driver bug that seems to cause shaders to be miscompiled. #1740

merged 1 commit into from Sep 21, 2017

Conversation

@mstange
Copy link
Contributor

mstange commented Sep 21, 2017 •
edited by larsbergstrom

Fixes #1368.
Fixes #1728.

This change is Reviewable
@mstange
Add workarounds for a driver bug that seems to cause shaders to be mi…
Loading status checks…
917da3c 
…scompiled.

Fixes #1368.
Fixes #1728.
@glennw
Copy link
Member

glennw commented Sep 21, 2017

Thanks! Could you list the exact hardware / OS you're running that has this driver bug here in the comments, and then we can reference that in the driver issues wiki page.

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 21, 2017

📌 Commit 917da3c has been approved by glennw
@bors-servo
Copy link
Contributor

bors-servo commented Sep 21, 2017

⌛ Testing commit 917da3c with merge 6e8bda7...
bors-servo added a commit that referenced this pull request Sep 21, 2017
@bors-servo
Auto merge of #1740 - mstange:workaround-intel-bug, r=glennw
Loading status checks…
6e8bda7 
Add workarounds for a driver bug that seems to cause shaders to be miscompiled.

Fixes #1368.
Fixes #1728.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1740)
<!-- Reviewable:end -->
@mstange
Copy link
Contributor Author

mstange commented Sep 21, 2017

I'm on macOS 10.12.6, my integrated GPU is an Intel HD Graphics 530 1536 MB (0x191b, Skylake GT2).
The text bug also happened on @paulrouget's machine which has an Intel Iris Graphics 550 1536 MB (probably 0x1927, Skylake GT3).

It does not happen on Jeff's machine, who has an Intel Iris Pro 1536 MB (0x0d26, Haswell GT3).
@bors-servo
Copy link
Contributor

bors-servo commented Sep 21, 2017

☀️ Test successful - status-travis
Approved by: glennw
Pushing 6e8bda7 to master...
@bors-servo bors-servo merged commit 917da3c into servo:master Sep 21, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@kvark
Copy link
Member

kvark commented Oct 5, 2017

OSX iGPU is a GL driver bug heaven :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@mstange @glennw @bors-servo @kvark
You can’t perform that action at this time.