Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix two bugs in linear gradient rendering. #175
Merged
Conversation
1. When the first stop of a gradient was not at position 0%, WebRender did not draw the solid color from 0% to that first stop, in violation of CSS-IMAGES-3. 2. Certain gradient angles would cause the segments to be too narrow. This patch fixes this by correcting the trigonometric calculations. Closes #161.
glennw
added a commit
that referenced
this pull request
Feb 5, 2016
Fix two bugs in linear gradient rendering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedFeb 5, 2016
did not draw the solid color from 0% to that first stop, in violation
of CSS-IMAGES-3.
This patch fixes this by correcting the trigonometric calculations.
Closes #161.