Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCull primitives with invalid dimensions, to avoid overflow later. #1768
Conversation
Primitives with invalid dimensions can cause overflow and general badness in the texture and render task allocators. Detect them and ensure they are not considered visible. Fixes servo/servo#18655
|
r? @nical or anyone |
|
@bors-servo r+ |
|
@bors-servo r=nical |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 28, 2017
Cull primitives with invalid dimensions, to avoid overflow later. Primitives with invalid dimensions can cause overflow and general badness in the texture and render task allocators. Detect them and ensure they are not considered visible. Fixes servo/servo#18655 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1768) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
glennw commentedSep 28, 2017
•
edited by larsbergstrom
Primitives with invalid dimensions can cause overflow and general
badness in the texture and render task allocators. Detect them
and ensure they are not considered visible.
Fixes servo/servo#18655
This change is