Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upExtra care of the upper bound for image tiling shader #1798
Conversation
|
Shader validation is failing on CI. Is it possible to add a reftest for this? It would be good to have test coverage for an edge case like this. |
|
@glennw should be better now |
|
Weird, I generated the image from |
|
@kvark I hate to be pedantic on this stuff - but we probably shouldn't include that image in the repo unless we know the licensing on it. Would it be possible to replace with a simple image we create that tests the issue in question? |
|
@glennw sure, that would be most optimal, just going to take a bit more effort. |
|
Replaced the image with a hand-generated one. |
|
Thanks! @bors-servo r+ |
|
|
Extra care of the upper bound for image tiling shader Fixes #1797 r? @glennw Gecko try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8a192063236587f0d93b5b85b0bf1c16108c3a6d <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1798) <!-- Reviewable:end -->
|
|
kvark commentedOct 3, 2017
•
edited
Fixes #1797
r? @glennw
Gecko try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8a192063236587f0d93b5b85b0bf1c16108c3a6d
This change is