Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse stencil buffer for clipping iframes and aabb tree nodes. #180
Conversation
|
r? @pcwalton (This relies on a related PR in servo before it can be merged). |
|
Could we file a followup to add the number of stencil buffer changes to |
src/util.rs
Outdated
| self.origin.x <= other.origin.x && | ||
| self.origin.y <= other.origin.y && | ||
| self.origin.x + self.size.width >= other.origin.x + other.size.width && | ||
| self.origin.y + self.size.height >= other.origin.y + other.size.height |
This comment has been minimized.
This comment has been minimized.
|
Looks good. |
glennw
added a commit
that referenced
this pull request
Feb 9, 2016
Use stencil buffer for clipping iframes and aabb tree nodes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
glennw commentedFeb 9, 2016
(This allows correct clipping for these cases when transforms are involved).
This is a partial fix for #177 (the other part relies on changes to layout).