Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to bincode 0.9 #1866

Merged
merged 1 commit into from Oct 13, 2017
Merged

Update to bincode 0.9 #1866

merged 1 commit into from Oct 13, 2017

Conversation

@staktrace
Copy link
Contributor

staktrace commented Oct 13, 2017

Same as #1858 but with the ipc-channel update as welll. I'm basically stealing this from jeff in the hope of landing it sooner as it is blocking even attempted WR updates in gecko.


This change is Reviewable

@staktrace
Copy link
Contributor Author

staktrace commented Oct 13, 2017

r? @glennw

@jrmuizel
Copy link
Contributor

jrmuizel commented Oct 13, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Oct 13, 2017

📌 Commit da0c6c6 has been approved by jrmuizel

@glennw
Copy link
Member

glennw commented Oct 13, 2017

@bors-servo r+ 🚀

@jrmuizel
Copy link
Contributor

jrmuizel commented Oct 13, 2017

And I'm stealn' the review

@bors-servo
Copy link
Contributor

bors-servo commented Oct 13, 2017

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #1855
@bors-servo
Copy link
Contributor

bors-servo commented Oct 13, 2017

📌 Commit da0c6c6 has been approved by glennw

@glennw glennw mentioned this pull request Oct 13, 2017
@glennw
Copy link
Member

glennw commented Oct 13, 2017

@bors-servo p=100

@bors-servo
Copy link
Contributor

bors-servo commented Oct 13, 2017

Testing commit da0c6c6 with merge 94727d1...

bors-servo added a commit that referenced this pull request Oct 13, 2017
Update to bincode 0.9

Same as #1858 but with the ipc-channel update as welll. I'm basically stealing this from jeff in the hope of landing it sooner as it is blocking even attempted WR updates in gecko.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1866)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 13, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: glennw
Pushing 94727d1 to master...

@bors-servo bors-servo merged commit da0c6c6 into servo:master Oct 13, 2017
4 checks passed
4 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@staktrace staktrace deleted the staktrace:bincode branch Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.