Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix diacritic glyphs on Linux. #1868
Merged
+13
−6
Conversation
|
Looks good! |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 14, 2017
Fix diacritic glyphs on Linux. Diacritic glyphs have a valid width and height, but a zero advance. Previously we were discarding these but they are valid glyphs. The code also checks for a width and height of 0 below, which catches non-printable glyphs such as spaces. Fixes #1846. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1868) <!-- Reviewable:end -->
|
|
|
|
|
@bors-servo r=kvark |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 15, 2017
Fix diacritic glyphs on Linux. Diacritic glyphs have a valid width and height, but a zero advance. Previously we were discarding these but they are valid glyphs. The code also checks for a width and height of 0 below, which catches non-printable glyphs such as spaces. Fixes #1846. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1868) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
glennw commentedOct 13, 2017
•
edited by larsbergstrom
Diacritic glyphs have a valid width and height, but a
zero advance. Previously we were discarding these but
they are valid glyphs. The code also checks for a width
and height of 0 below, which catches non-printable glyphs
such as spaces.
Fixes #1846.
This change is