Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix speed regressions in spheres demo #187
Merged
+86
−75
Conversation
This is vital because it is used as a hash key for raster ops. Before this change, two box shadows with the same parameters but different positions on screen would not hit the texture cache.
…ter ops. The renderer converts them to device pixels later anyway, so this shouldn't affect accuracy. This just means that fractional radii get the same hash key and hit the texture cache more often.
|
The first commit (to store the local raster origin) is the most important change, but both of these drastically reduce the number of box shadow raster ops in the spheres demo. On my machine, the spheres demo easily runs at 60fps with these changes. r? @pcwalton |
pcwalton
added a commit
that referenced
this pull request
Feb 18, 2016
Fix speed regressions in spheres demo
|
Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
glennw commentedFeb 18, 2016
No description provided.