Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bitflags to 1.0 #1879

Merged
merged 1 commit into from Oct 16, 2017
Merged

Bump bitflags to 1.0 #1879

merged 1 commit into from Oct 16, 2017

Conversation

@Eijebong
Copy link
Member

Eijebong commented Oct 15, 2017 •
edited by larsbergstrom

This change is Reviewable
@Eijebong
Bump bitflags to 1.0
Loading status checks…
0f3a627
@glennw
Copy link
Member

glennw commented Oct 15, 2017

Why do we need to allow duplicate packages in the servo-tidy script?
@Eijebong
Copy link
Member Author

Eijebong commented Oct 15, 2017

Because of clap which still depends on 0.9 :/ clap-rs/clap#1063
@glennw
Copy link
Member

glennw commented Oct 15, 2017

@Eijebong Ah, thanks for the info. clap is only used by wrench, so I guess this should be fine for Servo.

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 15, 2017

📌 Commit 0f3a627 has been approved by glennw
@glennw
Copy link
Member

glennw commented Oct 15, 2017

@bors-servo r-
@glennw
Copy link
Member

glennw commented Oct 15, 2017

@Eijebong Oh, wait - is the rustc stable version requirement going to cause an issue for Gecko compiling against WR?
@Eijebong
Copy link
Member Author

Eijebong commented Oct 15, 2017

servo/servo#18809 (comment) Shouldn't be an issue anymore no :)
@glennw
Copy link
Member

glennw commented Oct 15, 2017

@bors-servo r+

👍
@bors-servo
Copy link
Contributor

bors-servo commented Oct 15, 2017

📌 Commit 0f3a627 has been approved by glennw
@bors-servo
Copy link
Contributor

bors-servo commented Oct 15, 2017

⌛ Testing commit 0f3a627 with merge 0f4f519...
bors-servo added a commit that referenced this pull request Oct 15, 2017
@bors-servo
Auto merge of #1879 - Eijebong:bitflags, r=glennw
Loading status checks…
0f4f519 
Bump bitflags to 1.0

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1879)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: glennw
Pushing 0f4f519 to master...
@bors-servo bors-servo merged commit 0f3a627 into servo:master Oct 16, 2017
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@Eijebong Eijebong mentioned this pull request Oct 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@Eijebong @glennw @bors-servo
You can’t perform that action at this time.