Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite push_line interface, and make patterned lines match gecko closer #1923

Merged
merged 4 commits into from Oct 25, 2017
+244 −147
Merged

rewrite push_line interface, and make patterned lines match gecko closer #1923

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
978f234
rewrite push_line interface, and make wavy lines match gecko closer
Gankra Oct 23, 2017
5dee833
update wrench to use new line style
Gankra Oct 23, 2017
9bf89c7
Make dot and dash line shaders more precise
Gankra Oct 24, 2017
678098d
Make decoration suite more realistic/interesting.
Gankra Oct 24, 2017
File filter...
Filter file types
Clear filters
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Prev
Loading status checks…

Make decoration suite more realistic/interesting. 

Mostly adjusts sizes to be similar to what gecko produces, most notably
very thin lines. Also purposefully triggers some more corner cases in
the shaders and tries more shadow combinations.
  • Loading branch information
@Gankra
Gankra committed Oct 24, 2017
commit 678098d76aa7c1e83e209f6127e3fd6557a1b700
BIN -4.12 KB (86%) wrench/reftests/text/decorations-suite.png
View file
Open in desktop
Binary file not shown.
138 wrench/reftests/text/decorations-suite.yaml
View file
Open in desktop
@@ -5,23 +5,23 @@ root:
baseline: 10
start: 10
end: 210
width: 3
width: 1
orientation: horizontal
color: black
style: solid
- type: line
baseline: 20
start: 10
end: 210
width: 3
width: 1
orientation: horizontal
color: blue
style: dashed
- type: line
baseline: 30
start: 10
end: 210
width: 3
width: 1
orientation: horizontal
color: green
style: dotted
@@ -39,23 +39,23 @@ root:
baseline: 50
start: 10
end: 210
width: 8
width: 2
orientation: horizontal
color: black
style: solid
- type: line
baseline: 65
start: 10
end: 210
width: 8
width: 2
orientation: horizontal
color: blue
style: dashed
- type: line
baseline: 80
start: 10
end: 210
width: 8
end: 207 # pruposefully cut off
width: 2
orientation: horizontal
color: green
style: dotted
@@ -71,36 +71,120 @@ root:

-
type: "shadow"
bounds: [14, 18, 205, 35]
bounds: [8, 100, 225, 50]
blur-radius: 0
offset: [5, 7]
offset: [2, 2]
color: red
- type: line
baseline: 110
start: 10
end: 210
width: 1
orientation: horizontal
color: [0,0,0,0]
style: solid
- type: line
baseline: 120
start: 10
end: 210
width: 1
orientation: horizontal
color: [0,0,0,0]
style: dashed
- type: line
baseline: 130
start: 10
end: 209
width: 1
orientation: horizontal
color: [0,0,0,0]
style: dotted
- type: line
baseline: 140
start: 10
end: 210
width: 3
thickness: 1
orientation: horizontal
color: [0,0,0,0]
style: wavy
-
type: pop-all-shadows

-
type: "shadow"
bounds: [8, 145, 225, 65]
blur-radius: 1
offset: [2, 3]
color: red
- type: line
baseline: 150
start: 10
end: 210
width: 2
orientation: horizontal
color: black
style: solid
- type: line
baseline: 165
start: 10
end: 210
width: 2
orientation: horizontal
color: blue
style: dashed
- type: line
baseline: 180
start: 10
end: 207 # purposefully cut off
width: 2
orientation: horizontal
color: green
style: dotted
- type: line
baseline: 195
start: 10
end: 210
width: 6
thickness: 2
orientation: horizontal
color: red
style: wavy
-
type: pop-all-shadows

-
type: "shadow"
bounds: [8, 220, 225, 40]
blur-radius: 0
offset: [5, 7]
color: red
- type: line
baseline: 230
start: 10
end: 210
width: 8
orientation: horizontal
color: black
style: solid
- type: line
baseline: 150
baseline: 250
start: 10
end: 210
width: 8
orientation: horizontal
color: blue
style: dashed
- type: line
baseline: 170
baseline: 270
start: 10
end: 210
end: 205 # purposefully cut off
width: 8
orientation: horizontal
color: green
style: dotted
- type: line
baseline: 190
baseline: 290
start: 10
end: 210
width: 12
@@ -113,36 +197,36 @@ root:

-
type: "shadow"
bounds: [0, 200, 220, 120]
bounds: [0, 320, 240, 140]
blur-radius: 3
offset: [5, 7]
color: red
- type: line
baseline: 230
baseline: 330
start: 10
end: 210
width: 8
orientation: horizontal
color: black
style: solid
- type: line
baseline: 250
baseline: 350
start: 10
end: 210
width: 8
orientation: horizontal
color: blue
style: dashed
- type: line
baseline: 270
baseline: 370
start: 10
end: 210
end: 205 # purposefully cut off
width: 8
orientation: horizontal
color: green
style: dotted
- type: line
baseline: 290
baseline: 390
start: 10
end: 210
width: 16
@@ -157,23 +241,23 @@ root:
baseline: 220
start: 10
end: 210
width: 3
width: 1
orientation: vertical
color: black
style: solid
- type: line
baseline: 230
start: 10
end: 210
width: 3
width: 1
orientation: vertical
color: blue
style: dashed
- type: line
baseline: 240
start: 10
end: 210
width: 3
width: 1
orientation: vertical
color: green
style: dotted
@@ -191,23 +275,23 @@ root:
baseline: 270
start: 10
end: 210
width: 8
width: 2
orientation: vertical
color: black
style: solid
- type: line
baseline: 290
start: 10
end: 210
width: 8
width: 2
orientation: vertical
color: blue
style: dashed
- type: line
baseline: 310
start: 10
end: 210
width: 8
end: 207 # purposefully cut off
width: 2
orientation: vertical
color: green
style: dotted
@@ -246,7 +330,7 @@ root:
- type: line
baseline: 420
start: 10
end: 210
end: 205 # purposefully cut off
width: 8
orientation: vertical
color: green
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.