Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse primitive clip masks only, instead of sharing clip chain masks. #1960
Conversation
We're not getting any noticeable benefit from trying to share clip masks. In fact, we are often seeing very significant slowdowns since we over-estimate the size needed for a shared clip mask. This change drops the GPU time in #1817 from 40ms to 7ms on my machine - this is an extreme case, but it's faster in every site that I tested on locally. This is also a good simplification for upcoming changes, where we will be more aggressively removing clip masks when they are redundant, and drawing them in small segments where possible.
|
Ran this through the Servo WPT suite with no problems, and Gecko try looks good too: https://hg.mozilla.org/try/rev/f25d829728e34eadb9e76c3b57fd28ab21592dab |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 30, 2017
Use primitive clip masks only, instead of sharing clip chain masks. We're not getting any noticeable benefit from trying to share clip masks. In fact, we are often seeing very significant slowdowns since we over-estimate the size needed for a shared clip mask. This change drops the GPU time in #1817 from 40ms to 7ms on my machine - this is an extreme case, but it's faster in every site that I tested on locally. This is also a good simplification for upcoming changes, where we will be more aggressively removing clip masks when they are redundant, and drawing them in small segments where possible. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1960) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Oct 30, 2017
Use primitive clip masks only, instead of sharing clip chain masks. We're not getting any noticeable benefit from trying to share clip masks. In fact, we are often seeing very significant slowdowns since we over-estimate the size needed for a shared clip mask. This change drops the GPU time in #1817 from 40ms to 7ms on my machine - this is an extreme case, but it's faster in every site that I tested on locally. This is also a good simplification for upcoming changes, where we will be more aggressively removing clip masks when they are redundant, and drawing them in small segments where possible. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1960) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
glennw commentedOct 30, 2017
•
edited by larsbergstrom
We're not getting any noticeable benefit from trying to share clip
masks. In fact, we are often seeing very significant slowdowns
since we over-estimate the size needed for a shared clip mask.
This change drops the GPU time in #1817 from 40ms to 7ms on
my machine - this is an extreme case, but it's faster in every
site that I tested on locally.
This is also a good simplification for upcoming changes, where
we will be more aggressively removing clip masks when they
are redundant, and drawing them in small segments where possible.
This change is