Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for specifying an estimated background color for subpixel text #1974
Conversation
|
@mstange Wow, impressive doc! |
mstange
force-pushed the
mstange:subpixel-with-bg-color
branch
2 times, most recently
from
f1f9c09
to
3917267
mstange
changed the title
mstange
changed the title
mstange
force-pushed the
mstange:subpixel-with-bg-color
branch
5 times, most recently
from
c981381
to
8737117
|
@bors-servo r+ |
|
@lsalzman: |
|
The release tests are running into |
… text.
|
The test failures should be fixed now. |
|
@bors-servo r+ We should add some reftests for this too. |
|
|
Add support for specifying an estimated background color for subpixel text This is almost ready for review, but not quite. I've written some extensive documentation for the new text blending at `webrender/doc/text-rendering.md`: [Rendered](https://github.com/mstange/webrender/blob/subpixel-with-bg-color/webrender/doc/text-rendering.md) Remaining issues: - [x] rebase on top of Lee's changes to GlyphFormat - [x] decide whether it's reasonable to have individual font rasterization backends do `mask.a = mask.max_rgb` or whether that's cheap enough to do in the shader - conclusion: do it in the backends - [x] if the former, also fix up the linux and windows backends - [x] decide whether the middle pass should use a different shader so that regular text rendering doesn't have the overhead of the extra color field and the extra `if` in the fragment shader - conclusion: use different shader through an #ifdef in the text shader - ~~[ ] add some tests~~ filed #1980 to get test support <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1974) <!-- Reviewable:end -->
|
|
|
@staktrace @mstange Heads up - this PR adds a field to FontInstanceOptions struct that silently compiles in Gecko but results in random data for the background color field. I guess the FFI bindings will need to be regenerated? |
|
Oh, I see there's a patch ready for this in the wr-future bug, never mind me. |
mstange commentedNov 1, 2017
•
edited
This is almost ready for review, but not quite.
I've written some extensive documentation for the new text blending at
webrender/doc/text-rendering.md: RenderedRemaining issues:
mask.a = mask.max_rgbor whether that's cheap enough to do in the shader - conclusion: do it in the backendsifin the fragment shader - conclusion: use different shader through an #ifdef in the text shader[ ] add some testsfiled #1980 to get test supportThis change is