Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upOnly draw vertical and horizontal edge when border radius is less then border width #1975
Conversation
|
The CI is failing with these tests: It's possible they might just need to be re-generated, depending on what the differences are. You can run the tests locally with |
subsevenx2001
force-pushed the
subsevenx2001:bug1404158
branch
2 times, most recently
from
460c5f6
to
c881343
|
I ran reftest locally and corrected some logic, now this one is the only failed reftest. But the difference is so little that I cannot see it unless with "Circle the Difference" checked. Hi @glennw , is that the case which need ref image being regenerated? |
|
In that case, you can run |
|
@subsevenx2001 Is there any way we can add a new reftest that covers this change, to ensure we don't regress in the future? |
|
@glennw It seems that the bug itself only triggered in certain zoom ratio, and the ratio varies among different screen resolution, I am not sure how to trigger it with reftest since we don't have screen resolution in headless mode when performing reftest. |
|
@subsevenx2001 Yea, it could be tricky. I think I ported the test case at https://bug1404158.bmoattachments.org/attachment.cgi?id=8913468 to a wrench yaml file and was able to reproduce it when I was doing some testing. I've lost that file, but it's probably worth just converting that test case to a wrench YAML file and seeing if it reproduces. |
|
@glennw I see 1920x1080 when running the script generating reference image. I think maybe it is the base resolution when running headless mode, perhaps we can try reproducing it on a 1080p screen and convert it in YAML. |
…us is less then border width
|
Add a reftest for testing bogus line in border radius. |
|
I submitted a gecko try run for this: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a374b822433151bd6b29fabb26b78d7fe649cfc9 If it's all green, then this is good to merge. |
|
Try looks good, thanks! @bors-servo r+ |
|
|
Only draw vertical and horizontal edge when border radius is less then border width #1805 is caused by fragment shader incorrectly processes corner pixels outside the clip reigon which is originally written for handling border width > border radius case. This patch checks whether border radius is less than border width or not before drawing pixel. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1975) <!-- Reviewable:end -->
|
|
subsevenx2001 commentedNov 1, 2017
•
edited by larsbergstrom
#1805 is caused by fragment shader incorrectly processes corner pixels outside the clip reigon which is originally written for handling border width > border radius case.
This patch checks whether border radius is less than border width or not before drawing pixel.
This change is