New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't draw primitive runs of invisible clip nodes #2008

Merged
merged 1 commit into from Nov 7, 2017

Conversation

Projects
None yet
3 participants
@kvark
Member

kvark commented Nov 7, 2017

Fixes #2003
r? anyone


This change is Reviewable

@glennw

This comment has been minimized.

Show comment
Hide comment
@glennw

glennw Nov 7, 2017

Member

@kvark Code looks good - could we add a reftest that ensures we don't regress in future?

Member

glennw commented Nov 7, 2017

@kvark Code looks good - could we add a reftest that ensures we don't regress in future?

@kvark

This comment has been minimized.

Show comment
Hide comment
@kvark

kvark Nov 7, 2017

Member

I don't think this is achievable with a YAML test. It happens for me when I load, then scroll down (it populates the clip_task_id), then scroll up (clipping out some stuff).

Member

kvark commented Nov 7, 2017

I don't think this is achievable with a YAML test. It happens for me when I load, then scroll down (it populates the clip_task_id), then scroll up (clipping out some stuff).

@glennw

This comment has been minimized.

Show comment
Hide comment
@glennw

glennw Nov 7, 2017

Member

@bors-servo r+ 👍

Member

glennw commented Nov 7, 2017

@bors-servo r+ 👍

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Nov 7, 2017

Contributor

📌 Commit 0cc3812 has been approved by glennw

Contributor

bors-servo commented Nov 7, 2017

📌 Commit 0cc3812 has been approved by glennw

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Nov 7, 2017

Contributor

⌛️ Testing commit 0cc3812 with merge 24b3fa4...

Contributor

bors-servo commented Nov 7, 2017

⌛️ Testing commit 0cc3812 with merge 24b3fa4...

bors-servo added a commit that referenced this pull request Nov 7, 2017

Auto merge of #2008 - kvark:crash, r=glennw
Don't draw primitive runs of invisible clip nodes

Fixes #2003
r? anyone

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2008)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Nov 7, 2017

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: glennw
Pushing 24b3fa4 to master...

Contributor

bors-servo commented Nov 7, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: glennw
Pushing 24b3fa4 to master...

@bors-servo bors-servo merged commit 0cc3812 into servo:master Nov 7, 2017

4 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@kvark kvark deleted the kvark:crash branch Jul 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment