Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix some issues with scrollbars #2018
Merged
Conversation
|
|
webrender/src/frame_builder.rs
Outdated
| use util::{self, pack_as_float, RectHelpers, recycle_vec}; | ||
| use box_shadow::BLUR_SAMPLE_SCALE; | ||
|
|
||
| #[derive(Debug, Copy, Clone)] | ||
| pub enum PrimitiveFlags { |
This comment has been minimized.
This comment has been minimized.
kvark
Nov 9, 2017
Member
Isn't strictly related to this PR, but I think we should change this to something like Option<ScrollBar>
This comment has been minimized.
This comment has been minimized.
mrobinson
Nov 9, 2017
Author
Member
Okay. Sounds reasonable to me! The latest version of the PR has this change.
Scrollbars would scroll horizontally instead of sticking to the edge of the frame and were also not visible at all on iframes. This change fixes those issues by adding them to the containing reference frame. As part of this change, iframe background colors are also attached to the reference frame and only painted over the frame rect.
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Nov 9, 2017
Fix some issues with scrollbars Scrollbars would scroll horizontally instead of sticking to the edge of the frame and were also not visible at all on iframes. This change fixes those issues by adding them to the containing reference frame. As part of this change, iframe background colors are also attached to the reference frame and only painted over the frame rect. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2018) <!-- Reviewable:end -->
|
|
|
@bors-servo r=kvark |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 10, 2017
Fix some issues with scrollbars Scrollbars would scroll horizontally instead of sticking to the edge of the frame and were also not visible at all on iframes. This change fixes those issues by adding them to the containing reference frame. As part of this change, iframe background colors are also attached to the reference frame and only painted over the frame rect. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2018) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mrobinson commentedNov 9, 2017
•
edited by larsbergstrom
Scrollbars would scroll horizontally instead of sticking to the edge of
the frame and were also not visible at all on iframes. This change fixes
those issues by adding them to the containing reference frame. As part
of this change, iframe background colors are also attached to the
reference frame and only painted over the frame rect.
This change is